[iOS/macCatalyst] [Candidate Fix] Editor shadow and theme regression caused by BackgroundColor reset on initial handler connection#35343
Merged
kubaflo merged 2 commits intoMay 7, 2026
Conversation
Contributor
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
Bot
added
the
partner/syncfusion
Tamilarasan-Paranthaman
added
area-testing
sheiksyedm
changed the title
sheiksyedm
changed the title
kubaflo
approved these changes
May 7, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 25, 2026
…caused by BackgroundColor reset on initial handler connection (#35343) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Root Cause of the Regression PR #34741's MapBackground overrides call platformView.BackgroundColor = null during initial handler connection (when Background is null by default), making Editor controls transparent at startup — breaking shadow rendering and app-theme color bindings. ### Description of Change In EditorHandler.iOS.cs, replaced platformView.BackgroundColor = null with platformView.BackgroundColor = ColorExtensions.BackgroundColor (UIColor.SystemBackground) so the Editor restores the system's adaptive default color instead of becoming transparent. This preserves shadow rendering on initial load and correctly responds to light/dark theme changes. ### Issues Fixed UI Test iOS: VerifyEditorPlaceholderWithShadow, VerifyEditor_WithShadow, ShadowsDontRespectControlShape Mac: VerifyEditorPlaceholderWithShadow, VerifyEditor_WithShadow, ShadowsDontRespectControlShape, EditorAndEntryInputFieldsShouldChangeColorsOnAppThemeChange, EntryAndEditorPlaceholderTextColorAppThemeBindingUpdatesOnThemeChange, EntryAndEditorTextColorAppThemeBindingUpdatesOnThemeChange - Fails due to this PR - #34741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the Regression
PR #34741's MapBackground overrides call platformView.BackgroundColor = null during initial handler connection (when Background is null by default), making Editor controls transparent at startup — breaking shadow rendering and app-theme color bindings.
Description of Change
In EditorHandler.iOS.cs, replaced platformView.BackgroundColor = null with platformView.BackgroundColor = ColorExtensions.BackgroundColor (UIColor.SystemBackground) so the Editor restores the system's adaptive default color instead of becoming transparent. This preserves shadow rendering on initial load and correctly responds to light/dark theme changes.
Issues Fixed
UI Test
iOS:
VerifyEditorPlaceholderWithShadow, VerifyEditor_WithShadow, ShadowsDontRespectControlShape
Mac:
VerifyEditorPlaceholderWithShadow, VerifyEditor_WithShadow, ShadowsDontRespectControlShape, EditorAndEntryInputFieldsShouldChangeColorsOnAppThemeChange, EntryAndEditorPlaceholderTextColorAppThemeBindingUpdatesOnThemeChange, EntryAndEditorTextColorAppThemeBindingUpdatesOnThemeChange - Fails due to this PR - #34741